Do not append genesis during fork #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
requested review from
dahlia,
longfin,
earlbread,
riemannulus and
moreal
earlbread
reviewed
Oct 30, 2020
Libplanet/Blockchain/BlockChain.cs
Outdated
| renderActions: !inFork, | ||
| evaluateActions: !inFork | ||
| ); | ||
| if (!inFork) |
There was a problem hiding this comment.
How merge if statements?
Suggested change
| if (!inFork) | |
| if (count == 0 && !inFork) |
There was a problem hiding this comment.
It will throw exception in next else if statement 😢
dahlia
previously approved these changes
Oct 30, 2020
Libplanet/Blockchain/BlockChain.cs
Outdated
Comment on lines
175
to
177
| if (Count == 0) | ||
| { | ||
| Append( | ||
| genesisBlock, | ||
| currentTime: genesisBlock.Timestamp, | ||
| renderBlocks: !inFork, | ||
| renderActions: !inFork, | ||
| evaluateActions: !inFork | ||
| ); | ||
| if (!inFork) |
There was a problem hiding this comment.
How about merging two conditions into one using an && operator?
There was a problem hiding this comment.
Oh, fair enough. Never mind.
There was a problem hiding this comment.
It will throw exception in next else if statement 😢
limebell
force-pushed
the
refactor/skip-genesis-infork
branch
from
b84b871 to
e5ca06e
Compare
|
I made constructor of |
longfin
reviewed
Nov 2, 2020
limebell
force-pushed
the
refactor/skip-genesis-infork
branch
from
e5ca06e to
534d8a5
Compare
longfin
approved these changes
Nov 2, 2020
earlbread
approved these changes
Nov 2, 2020
Codecov Report
@@ Coverage Diff @@
## 9c-main #1063 +/- ##
===========================================
- Coverage 88.44% 88.37% -0.07%
===========================================
Files 343 343
Lines 31490 31494 +4
===========================================
- Hits 27850 27834 -16
- Misses 1962 1980 +18
- Partials 1678 1680 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InsteadIStore.ForkBlockIndexes()became to iterate from 0 (was 1).Instead just append its index only.