-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More events on renderers #1000
More events on renderers #1000
Conversation
Reorganized RenderRecord into hierarchical layers. [changelog skip]
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 88.98% 89.08% +0.10%
==========================================
Files 328 328
Lines 29481 29702 +221
==========================================
+ Hits 26233 26460 +227
+ Misses 1694 1684 -10
- Partials 1554 1558 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newly introduced events should be listed on the CHANGES.md
.
@limebell As |
I guess we should add it here at least?
|
[changelog skip]
[changelog skip]
5b44904
4ae4f34
to
5b44904
Compare
@planetarium/libplanet Added missing unit tests and changelogs! Please review this again. |
To follow up the API changes made from <planetarium/libplanet#1000>.
Added two more render methods:
IActionRenderer<T>.RenderBlockEnd()
IRenderer<T>.RenderReorgEnd()
See also the docs on
IRenderer<T>
:… and
IActionRenderer<T>
:By utilizing
RenderBlockEnd()
event,DelayedActionRenderer<T>
became to atomically update its internal buffers (it's further than the approach made in #998).I also refactored
DumRenderer<T>
(in the tests project) intoRecordingRenderer<T>
to reorganizeRenderRecord
into hierarchical layers.