-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen constraint about Block.Timestamp #65
Labels
suggestion
Suggestion or feature request
Comments
If the existing code is assuming that the order of blocks are determined by its timestamp we should get rid of the assumption as well. To me both of styles are fine. |
longfin
added a commit
to longfin/libplanet.net
that referenced
this issue
Feb 12, 2019
longfin
added a commit
to longfin/libplanet.net
that referenced
this issue
Feb 12, 2019
longfin
added a commit
to longfin/libplanet.net
that referenced
this issue
Feb 12, 2019
longfin
added a commit
to longfin/libplanet.net
that referenced
this issue
Feb 12, 2019
longfin
added a commit
to longfin/libplanet.net
that referenced
this issue
Feb 12, 2019
longfin
added a commit
that referenced
this issue
Feb 12, 2019
Loosen Block.Timestamp constraints (#65)
dahlia
pushed a commit
to dahlia/libplanet
that referenced
this issue
Mar 9, 2021
Bump libplanet version 0.7.0-nightly.20191015
limebell
pushed a commit
to limebell/libplanet
that referenced
this issue
Jul 7, 2021
Introduce Lib9c.Tools
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this issue
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we require that the generated block has a timestamp higher than the timestamp of the previous block. there are a few things to consider.
Block.Timestamp
isn't always accurate because they are based on the local time of the system.I think we'd better loosen this constraint like Ethereum or Bitcoin style.
block.timestamp <= now + 900
and isblock.timestamp >= parent.timestamp
. (see also)There are pros and cons, but I think the Ethereum style is more intuitive and easier to implement.
@dahlia @kijun @ipdae any ideas?
The text was updated successfully, but these errors were encountered: