Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of Peer.EndPoint to enable DNS lookup #165

Closed
longfin opened this issue Apr 1, 2019 · 0 comments · Fixed by #166
Closed

Change type of Peer.EndPoint to enable DNS lookup #165

longfin opened this issue Apr 1, 2019 · 0 comments · Fixed by #166
Assignees
@longfin

Comments

@longfin
Copy link
Member

longfin commented Apr 1, 2019 •
edited
Loading

We've chosen IPEndPoint to represent Peer.EndPoint in #120 . but IPEndPoint can't represent address using DNS. (e.g. seed.nekoyume.game) so we should replace it to with DnsEndPoint or EndPoint
@longfin longfin self-assigned this Apr 1, 2019
@longfin longfin changed the title Change type of Peer.Url to enable DNS lookup Change type of Peer.EndPoint to enable DNS lookup Apr 1, 2019
@longfin longfin mentioned this issue Apr 1, 2019
Merged
limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
@dahlia
Merge pull request planetarium#165 from dahlia/analyzer
2849d2a 
Fix a broken deployment job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longfin longfin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change type of Peer.EndPoint to DnsEndPoint longfin/libplanet.net
1 participant
@longfin