Don't try to catch up after slowdown when using fixed rate #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With fixed rate limit, if there is sudden slowdown and the database can't keep up, latte should not try to issue more requests in burst after the slow-down is over. With this fix it will keep the maximum set rate limit.
vponomaryov
added a commit
to scylladb/latte
that referenced
this pull request
Oct 28, 2024
This is kind of revert for the following PR: - pkolaczk#89 We need exactly 'burst' approach and not 'skip' one. Scylla failures will be mitigated with retries mechanism.
vponomaryov
added a commit
to scylladb/latte
that referenced
this pull request
Oct 28, 2024
This is kind of revert for the following PR: - pkolaczk#89 We need exactly 'burst' approach and not 'skip' one. Scylla failures will be mitigated with retries mechanism.
vponomaryov
added a commit
to scylladb/latte
that referenced
this pull request
Oct 28, 2024
This is kind of revert for the following PR: - pkolaczk#89 We need exactly 'burst' approach and not 'skip' one. Scylla failures will be mitigated with retries mechanism.
vponomaryov
added a commit
to scylladb/latte
that referenced
this pull request
Oct 28, 2024
This is kind of revert for the following PR: - pkolaczk#89 We need exactly 'burst' approach and not 'skip' one. Scylla failures will be mitigated with retries mechanism.
vponomaryov
added a commit
to scylladb/latte
that referenced
this pull request
Oct 29, 2024
This is kind of revert for the following PR: - pkolaczk#89 We need exactly 'burst' approach and not 'skip' one. Scylla failures will be mitigated with retries mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With fixed rate limit, if there is sudden slowdown and the
database can't keep up, latte should not try to issue
more requests in burst after the slow-down is over.
With this fix it will keep the maximum set rate limit.