Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#91/feature/jsp/app enhancement3 #143

Merged
merged 10 commits into from
Jun 8, 2023
Merged

#91/feature/jsp/app enhancement3 #143

merged 10 commits into from
Jun 8, 2023

Conversation

pknujsp
Copy link
Collaborator

@pknujsp pknujsp commented Jun 8, 2023

πŸ“Œ κ΄€λ ¨ 이슈

#91

✨ 과제 λ‚΄μš©

πŸ“Έ μŠ€ν¬λ¦°μƒ·(선택)

πŸ“š 레퍼런슀 (λ˜λŠ” μƒˆλ‘œ μ•Œκ²Œ 된 λ‚΄μš©) ν˜Ήμ€ κΆκΈˆν•œ 사항듀

pknujsp added 9 commits June 8, 2023 03:34
@pknujsp
#91 λŒ“κΈ€ κΈ°λŠ₯ κ΅¬ν˜„ μ™„λ£Œ
60a7aef
@pknujsp
#91 카메라 였λ₯˜ μˆ˜μ •
60c4638
@pknujsp
#91 관심 μ•½ 처리 데이터 λͺ¨λΈ 생성
cf0bda5
@pknujsp
#91 관심 μ•½ 처리 DataSource λ‘œμ§μΆ”κ°€
e35e458
@pknujsp
#91 μ•½ 관심 μΆ”κ°€/λͺ©λ‘/μ‚­μ œ/확인 둜직 데이터 μ˜μ—­ λΆ€λΆ„ μž‘μ—… μ™„
6924768
@pknujsp
#91 μ•½ 관심 처리 둜직 μ œμž‘ μ™„λ£Œ
1f57020
@pknujsp
#91 관심 μ•½ κ΄€λ ¨ 데이터 λͺ¨λΈ νŒ¨ν‚€μ§€ 였λ₯˜ μˆ˜μ •
9b97aee
@pknujsp
#91 λ„€νŠΈμ›Œν¬ μ—°κ²° 확인 λ‹€μ΄μ–Όλ‘œκ·Έ μΆ”κ°€
17b1b81
@pknujsp
#91 λ„€νŠΈμ›Œν¬ μ—°κ²° 확인 λ‹€μ΄μ–Όλ‘œκ·Έ μž‘μ—… μ™„λ£Œ
7a89aaa
@pknujsp pknujsp requested a review from tgyuuAn June 8, 2023 04:45
tgyuuAn
tgyuuAn approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@tgyuuAn tgyuuAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„ˆλ¬΄ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€...!

app/src/main/AndroidManifest.xml
android:theme="@style/Theme.MediProject"
android:usesCleartextTraffic="true">
<activity
android:name=".MainActivity"
android:exported="true"
android:screenOrientation="portrait"
android:theme="@style/Theme.App.Starting"
android:windowSoftInputMode="adjustResize|adjustPan">
android:windowSoftInputMode="adjustUnspecified">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edittext κ΄€λ ¨ μ½”λ“œλ§žμ£ ?!

core/common/src/main/res/values/strings.xml
@@ -72,4 +72,5 @@
<string name="efficacyGroupDuplicationCaution">효λŠ₯κ΅° 쀑볡</string>
<string name="divisionCaution">λΆ„ν•  주의</string>
<string name="additiveCaution">μ²¨κ°€μ œ 주의</string>
<string name="noInternetConnection">인터넷 연결이 ν•„μš”ν•©λ‹ˆλ‹€.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인터넷 μ—°κ²° λ‘œμ§λ„ ν•˜μ…¨λ‚˜μš” γ…Žγ„·γ„·

core/model/src/main/java/com/android/mediproject/core/model/comments/CommentDto.kt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 λΆ€λΆ„ μ œκ°€ μ €λ²ˆμ— λ³΄μ—¬λ“œλ Έλ˜ AdapterViewModel κ°™μ€κ±Έλ‘œ μ²˜λ¦¬ν•˜λ©΄ μ–΄λ• μ„κΉŒμš”?? 콜백 νŒŒλΌλ―Έν„°κ°€ λ§Žμ•„μ§€λŠ” 것 κ°™μ•„μ„œμš”..!

@pknujsp pknujsp merged commit d576bea into android_develop Jun 8, 2023
@pknujsp pknujsp deleted the #91/feature/jsp/app_enhancement3 branch July 14, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgyuuAn tgyuuAn tgyuuAn approved these changes

Assignees

@pknujsp pknujsp

Labels
λ°•μ€€μ„± 섀계 Improvements or additions to documentation μ•ˆλ“œλ‘œμ΄λ“œ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pknujsp @tgyuuAn