-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add source property to playlist items to support remote playlist entries #1335
Conversation
A Playlist entry if added a remote server item has field "source" initialized with value like `server://<server_id>/com.plexapp.plugins.library`
here's diff of keys local vs remote playlist entries. i guess some fields like titleSort rather vary on whether item has sort title set. --- pl-local-keys.json 2024-01-08 03:38:13
+++ pl-remote-keys.json 2024-01-08 03:38:28
@@ -6,17 +6,17 @@
"duration",
"guid",
"key",
- "librarySectionID", // local
- "librarySectionKey", // local
- "librarySectionTitle", // local
+ "originalTitle", // remote
"originallyAvailableAt",
"playlistItemID",
"ratingKey",
+ "source", // remote
"studio",
"summary",
+ "tagline", // remote
"thumb",
"title",
+ "titleSort", // remote
"type",
- "updatedAt", // local
"year"
] |
E261 at least two spaces before inline comment
This is unforunate, this seems to conflict with History object:
as apparently |
What is a "remote playlist entry"? Do you mean on someone else's server? What is the Plex URL endpoint where we can see this |
The I need to think about what to do about the conflicting |
maybe add this new property with the name "remote_source"? |
I think we name the attribute References: python-plexapi/plexapi/server.py Lines 172 to 173 in b51aa19
python-plexapi/plexapi/playqueue.py Line 27 in b51aa19
|
Updated: 3d7fd9e |
Co-authored-by: JonnyWong16 <[email protected]>
Co-authored-by: JonnyWong16 <[email protected]>
Co-authored-by: JonnyWong16 <[email protected]>
Co-authored-by: JonnyWong16 <[email protected]>
no longer breaking change label |
Description
A Playlist entry if added a remote server item has field "source" initialized with value like
server://<server_id>/com.plexapp.plugins.library
The
source
attribute should be onType of change
Please delete options that are not relevant.
Checklist: