Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all configurable PKGX_DIST_URL #72

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

jhheider
Copy link
Contributor

closes #71

@jhheider jhheider force-pushed the allow-configurable-dist-endpoint branch 2 times, most recently from af7e556 to 3dfdcee Compare May 10, 2024 14:50
@jhheider jhheider marked this pull request as draft May 10, 2024 15:01
@jhheider
Copy link
Contributor Author

i don't see where this change would have made unicode's package.yml unparseable... @mxcl does this look like some other regression to you?

@mxcl
Copy link
Member

mxcl commented May 10, 2024

Yeah cannot be due to this change. But what can it be? deno varies yes, but the deno std lib that parses yaml is pinned.

@mxcl
Copy link
Member

mxcl commented May 10, 2024

@jhheider
Copy link
Contributor Author

Running CI on main https://github.com/pkgxdev/libpkgx/actions/runs/9037714306

well, the failure is some kind of relief, certainly.

@jhheider
Copy link
Contributor Author

i was thinking the problem could have unicode characters and linux charsets; but hexedit scanning of that file doesn't support it, and most of the rest of our stack should complain if that were it.

@jhheider jhheider marked this pull request as ready for review May 10, 2024 20:30
@jhheider jhheider requested a review from mxcl May 10, 2024 20:30
@mxcl mxcl force-pushed the allow-configurable-dist-endpoint branch from 3dfdcee to 620dd77 Compare September 6, 2024 11:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10737221966

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 83.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useConfig.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 10737200673: 0.07%
Covered Lines: 2446
Relevant Lines: 2878

💛 - Coveralls

@mxcl mxcl merged commit 4409fe4 into main Sep 6, 2024
7 of 8 checks passed
@mxcl mxcl deleted the allow-configurable-dist-endpoint branch September 6, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgx distribution host endpoint override
3 participants