Skip to content

Commit

Permalink
refactor: move from eslint-plugin-node to eslint-plugin-n
Browse files Browse the repository at this point in the history
`eslint-plugin-node` is not maintained anymore mysticatea/eslint-plugin-node#300
  • Loading branch information
pkerschbaum committed Oct 23, 2023
1 parent 2def126 commit 69ad49e
Show file tree
Hide file tree
Showing 6 changed files with 64 additions and 62 deletions.
2 changes: 1 addition & 1 deletion packages/commons-ecma/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"eslint-plugin-code-import-patterns": "^3.0.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-only-warn": "^1.1.0",
"eslint-plugin-regexp": "^1.15.0",
"eslint-plugin-unicorn": "^48.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"eslint-plugin-code-import-patterns": "^3.0.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-only-warn": "^1.1.0",
"eslint-plugin-regexp": "^1.15.0",
"eslint-plugin-unicorn": "^48.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/fetch-favicon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"eslint-plugin-code-import-patterns": "^3.0.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-only-warn": "^1.1.0",
"eslint-plugin-regexp": "^1.15.0",
"eslint-plugin-unicorn": "^48.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/pkg-management/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"eslint-plugin-code-import-patterns": "^3.0.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-only-warn": "^1.1.0",
"eslint-plugin-regexp": "^1.15.0",
"eslint-plugin-unicorn": "^48.0.1",
Expand Down
32 changes: 16 additions & 16 deletions platform/config-eslint/eslint-ecma.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {
*/
'only-warn',
'@typescript-eslint/eslint-plugin',
'node',
'n',
'regexp',
'code-import-patterns',
],
Expand All @@ -26,7 +26,7 @@ module.exports = {
'plugin:regexp/recommended',
'plugin:import/recommended',
'plugin:import/typescript',
'plugin:node/recommended',
'plugin:n/recommended',
'plugin:unicorn/recommended',
'plugin:eslint-comments/recommended',
'prettier',
Expand Down Expand Up @@ -94,20 +94,20 @@ module.exports = {
],
},
],
'node/handle-callback-err': 'error',
'node/no-callback-literal': 'error',
// disable "node/no-extraneous-import" --> thanks to "isolated mode" of node_modules of pnpm and "public-hoist-pattern" being disabled of this monorepo, there is no possibilty for extraneous imports
'node/no-extraneous-import': 'off',
// disable "node/no-missing-import" --> covered by TypeScript
'node/no-missing-import': 'off',
'node/no-process-env': 'error',
'node/no-sync': 'error',
// disable "node/no-unsupported-features/es-syntax" --> covered by TypeScript
'node/no-unsupported-features/es-syntax': 'off',
// disable "node/no-unsupported-features/es-builtins" --> covered by TypeScript
'node/no-unsupported-features/es-builtins': 'off',
// disable "node/no-unsupported-features/node-builtins" --> covered by TypeScript
'node/no-unsupported-features/node-builtins': 'off',
'n/handle-callback-err': 'error',
'n/no-callback-literal': 'error',
// disable "n/no-extraneous-import" --> thanks to "isolated mode" of node_modules of pnpm and "public-hoist-pattern" being disabled of this monorepo, there is no possibilty for extraneous imports
'n/no-extraneous-import': 'off',
// disable "n/no-missing-import" --> covered by TypeScript
'n/no-missing-import': 'off',
'n/no-process-env': 'error',
'n/no-sync': 'error',
// disable "n/no-unsupported-features/es-syntax" --> covered by TypeScript
'n/no-unsupported-features/es-syntax': 'off',
// disable "n/no-unsupported-features/es-builtins" --> covered by TypeScript
'n/no-unsupported-features/es-builtins': 'off',
// disable "n/no-unsupported-features/node-builtins" --> covered by TypeScript
'n/no-unsupported-features/node-builtins': 'off',
'unicorn/filename-case': 'off',
'unicorn/no-negated-condition': 'off',
'unicorn/no-null': 'off',
Expand Down
86 changes: 44 additions & 42 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 69ad49e

Please sign in to comment.