Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy assert allclose for array testing #56

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

pkeilbach
Copy link
Owner

@pkeilbach pkeilbach commented Dec 19, 2023

Due to floating point arithmetics, some test cases failed because of

Due to numerical precision issues in floating-point arithmetic, some tests failed. I use numpy.testing.assert_allclose now to compare array values

closes #53

@pkeilbach pkeilbach self-assigned this Dec 19, 2023
@pkeilbach pkeilbach added the bug Something isn't working label Dec 19, 2023
@pkeilbach pkeilbach requested a review from MarcoMollo December 19, 2023 17:03
@pkeilbach pkeilbach enabled auto-merge (squash) December 19, 2023 17:12
@pkeilbach pkeilbach disabled auto-merge December 20, 2023 17:21
@pkeilbach pkeilbach merged commit f269d6b into main Dec 20, 2023
@pkeilbach pkeilbach deleted the issue-53-fix-naive-bayes-tests branch December 20, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small mathematical difference when using np.log
2 participants