rbd: flattern image when it has references to parent

Currently as part of node service we add rbd flatten task for new PVC creates. Ideally we should add flatten task only for snapshots/cloned PVCs as required. Fixes: ceph#1543 Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever · Sep 29, 2020 · b0c17f0 · b0c17f0
1 parent b9dd54e
commit b0c17f0
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/internal/rbd/nodeserver.go b/internal/rbd/nodeserver.go
@@ -238,6 +238,7 @@ func (ns *NodeServer) stageTransaction(ctx context.Context, req *csi.NodeStageVo
 	var err error
 	var readOnly bool
 	var feature bool
+	var depth uint
 
 	var cr *util.Credentials
 	cr, err = util.NewUserCredentials(req.GetSecrets())
@@ -273,7 +274,13 @@ func (ns *NodeServer) stageTransaction(ctx context.Context, req *csi.NodeStageVo
 			if err != nil {
 				return transaction, err
 			}
-			if feature {
+
+			depth, err = volOptions.getCloneDepth(ctx)
+			if err != nil {
+				return transaction, err
+			}
+
+			if feature && (depth != 0) {
 				err = volOptions.flattenRbdImage(ctx, cr, true, rbdHardMaxCloneDepth, rbdSoftMaxCloneDepth)
 				if err != nil {
 					return transaction, err