#7255: Remove data-pb-ready attribute
#8120
Conversation
| @@ -19,7 +19,6 @@ const knipConfig = { | |||
| "static/*", | |||
|
|
|||
| // App messenger and common storage | |||
| "src/contentScript/externalProtocol.ts", | |||
There was a problem hiding this comment.
This was the content-script-based messenger we had to implement because Firefox lacks onConnectExternal
Should have been dropped with
Dropped here because it awaited the data-pb-ready attribute
|
|
||
| onContextInvalidated.addListener(() => { | ||
| unsetReadyInThisDocument(uuid); |
There was a problem hiding this comment.
Refer to the updated @file notes.
In short, "readiness" is not part of the document anymore, so it does not need to be unset. Each content script remains forever "ready" yet unconnectable.
| export function isInstalledInThisSession(): boolean { | ||
| return CONTENT_SCRIPT_INJECTED_SYMBOL in globalThis; | ||
| export function isContentScriptInstalled(): boolean { | ||
| return CONTENT_SCRIPT_INJECTED_SYMBOL in window; |
There was a problem hiding this comment.
No globalThis support for symbols in TypeScript. This preserves consistency with the set* functions below
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main pixiebrix/pixiebrix-extension#8120 +/- ##
==========================================
+ Coverage 73.19% 73.29% +0.10%
==========================================
Files 1310 1309 -1
Lines 40732 40670 -62
Branches 7569 7558 -11
==========================================
- Hits 29814 29811 -3
+ Misses 10918 10859 -59 ☔ View full report in Codecov by Sentry. |
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
|
Tested, I didn't see any issues with the page editor, sidebar, and quickbar. Could not test the app communication because |
What does this PR do?
Checklist