Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error on duplicate webext-messenger execution #6856

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Nov 11, 2023

What does this PR do?

The actual changes code are in the following PR

Reviewer Tips

This PR doesn't yet include the attached PR, but you can see the result in the demo below

Discussion

As found in pixiebrix/webext-messenger#88, this is the easiest way to make the error visible without losing DX and causing further issues.

Demo

In the first commit of this PR, you can see the code triggering the error:

  • on CI
  • at runtime, even for files not covered by CI:
Screenshot 2

Checklist

  • Add tests: I clarified the CI checks
  • Designate a primary reviewer: @BLoe

Potentially related

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6823904) 70.41% compared to head (8e6f052) 70.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6856   +/-   ##
=======================================
  Coverage   70.41%   70.42%           
=======================================
  Files        1195     1195           
  Lines       37140    37140           
  Branches     6968     6968           
=======================================
+ Hits        26153    26154    +1     
+ Misses      10987    10986    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fregante fregante marked this pull request as ready for review November 14, 2023 10:56
@fregante fregante requested a review from BLoe November 14, 2023 10:56
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fregante fregante merged commit 6948811 into main Nov 16, 2023
@fregante fregante deleted the F/dx/highlight-bad-import branch November 16, 2023 23:15
@grahamlangford grahamlangford added this to the 1.8.3 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants