Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button texts that feel a little clunky. #22

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

hsychla
Copy link
Contributor

@hsychla hsychla commented Aug 2, 2019

No description provided.

@lnikell
Copy link
Member

lnikell commented Aug 2, 2019

@hsychla do you mean that those texts are grammatically incorrect?

@hsychla
Copy link
Contributor Author

hsychla commented Aug 2, 2019

@lnikell I think so. I am not a native english speaker but claim to have a good feeling for it.

At latest, when there is more than one file, the "a" in the text becomes wrong.

You can say "Open a file".
You can also say "Open file".
So for a single file, both versions are correct.

But, you would not say "Open a files" while "Open files" is ok.
So for more than one file the old version is not correct but the new version is.

@lnikell
Copy link
Member

lnikell commented Aug 2, 2019

@hsychla Thanks! I'm mostly curious in case that we use "Open a File(s)" so it's singular + (plural), so not sure should we focus on the plural version or singular from grammar perspective in that case:)

@hsychla
Copy link
Contributor Author

hsychla commented Aug 2, 2019

@lnikell That's the thing: I don't think that "Open a File(s)" is singular and plural because it expands to "Open a file" + "Open a files". The second case doesn't sound right.

"Open file(s)", on the other hand expands to "Open file" + "Open files". Both sound right, imho.

@lnikell
Copy link
Member

lnikell commented Aug 2, 2019

it makes sense, thank you for clarfication @hsychla

@lnikell lnikell merged commit 182ca74 into pixel-point:master Aug 2, 2019
@hsychla hsychla deleted the buttontexts branch August 2, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants