fix: value to LinkField can by None

pity7736 · Sep 9, 2020 · c4648a8 · c4648a8
1 parent db64857
commit c4648a8
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 28 deletions.
diff --git a/nyoibo/fields.c b/nyoibo/fields.c
diff --git a/nyoibo/fields.pyx b/nyoibo/fields.pyx
@@ -164,7 +164,7 @@ cdef class LinkField(Field):
         self.to = to
 
     cpdef public parse(self, value):
-        if isinstance(value, self.to):
+        if value is None or isinstance(value, self.to):
             return value
         raise FieldValueError(f'{type(value)} is not a valid value for '
                               f'{self.__class__.__name__}')
diff --git a/tests/test_fields.py b/tests/test_fields.py
@@ -185,10 +185,17 @@ class NewEntity(Entity):
 
     link_field = fields.LinkField(to=NewEntity)
     new_entity = NewEntity()
-
     assert link_field.parse(new_entity) == new_entity
 
 
+def test_parse_none_link_field():
+    class NewEntity(Entity):
+        pass
+
+    link_field = fields.LinkField(to=NewEntity)
+    assert link_field.parse(None) is None
+
+
 wrong_link_values = (
     '123',
     123,