Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded httpretty version; fixing #40 #41

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

nikicc
Copy link
Contributor

@nikicc nikicc commented Nov 16, 2015

httpretty==0.8.6 cannot be installed with LANG=C and consequently neither can be smart_open (and gensim). This pull relaxes the version constrains since the bug was fixed in 0.8.8.

@nikicc nikicc changed the title [WIP] Upgraded httpretty version; fixing #40 Upgraded httpretty version; fixing #40 Nov 16, 2015
@piskvorky
Copy link
Owner

Thanks!

piskvorky added a commit that referenced this pull request Nov 16, 2015
Upgraded httpretty version; fixing #40
@piskvorky piskvorky merged commit 1fe93a2 into piskvorky:master Nov 16, 2015
@nikicc
Copy link
Contributor Author

nikicc commented Nov 16, 2015

Awesome! BTW, approximately when can we expect new version on pypi?

@nikicc nikicc deleted the httpretty-upgrade branch November 16, 2015 10:54
@piskvorky
Copy link
Owner

I think after #38 and #39 are merged (only tests missing). CC @tmylk

@nikicc
Copy link
Contributor Author

nikicc commented Nov 16, 2015

Great, thanks!

@tmylk tmylk mentioned this pull request Dec 16, 2015
@nikicc
Copy link
Contributor Author

nikicc commented Dec 18, 2015

Just figured out that this was bad. Actually, the first version of httpretty that work with LC_ALL=C is 0.8.12 and not >=0.8.8 as was proposed by this PR. To work with LC_ALL=C this should be set to >=0.8.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants