Skip to content

Commit

Permalink
win: fix NODE_NET_SOCKET_READ/WRITE signature
Browse files Browse the repository at this point in the history
The NODE_NET_SOCKET_READ and NODE_NET_SOCKET_WRITE macros are just
no-ops on Windows, but they used to be defined as taking four parameters
while being called with five arguments. Turn them into variadic macros
to squelch a compiler warning.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
piscisaureus committed Jan 8, 2015
1 parent 09fe6fe commit 858b558
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/node_win32_etw_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,9 @@ INLINE bool NODE_NET_SOCKET_READ_ENABLED();
INLINE bool NODE_NET_SOCKET_WRITE_ENABLED();
INLINE bool NODE_V8SYMBOL_ENABLED();

#define NODE_NET_SOCKET_READ(arg0, arg1, arg2, arg3)
#define NODE_NET_SOCKET_WRITE(arg0, arg1, arg2, arg3)
#define NODE_NET_SOCKET_READ(...) /* no-op */
#define NODE_NET_SOCKET_WRITE(...) /* no-op */

} // namespace node

#endif // SRC_NODE_WIN32_ETW_PROVIDER_H_

0 comments on commit 858b558

Please sign in to comment.