Remove C++17 support #590
Merged
Remove C++17 support #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 93.86% 93.84% -0.03%
==========================================
Files 80 80
Lines 3882 3882
==========================================
- Hits 3644 3643 -1
- Misses 238 239 +1 ☔ View full report in Codecov by Sentry. |
elshize
force-pushed
the
only-cxx20
branch
2 times, most recently
from
2ce7318 to
8101f44
Compare
Signed-off-by: Michal Siedlaczek <[email protected]>
The CMake parameters for C++ standard and concepts are removed, and the code is updated accordingly. We use `[[likely]]` and `[[unlikely]]` instead of a macro. We also remove the macros for concepts, and use unconditional `static_assert` and `require`. Changelog-changed: C++17 is no longer supported Signed-off-by: Michal Siedlaczek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake parameters for C++ standard and concepts are removed, and the
code is updated accordingly. We use
[[likely]]and[[unlikely]]instead of a macro. We also remove the macros for concepts, and use
unconditional
static_assertandrequire.