Verify quantized index after compression #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `--check` flag to take effect when compressing an index. Signed-off-by: Michal Siedlaczek <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 90 90
Lines 4452 4454 +2
=======================================
+ Hits 4153 4155 +2
Misses 299 299 ☔ View full report in Codecov by Sentry. |
elshize
force-pushed
the
check-quantized
branch
from
70c485a to
b3f0f13
Compare
Make the implementation cleaner and compute term component only once per term scorer instead of for each score. Signed-off-by: Michal Siedlaczek <[email protected]>
elshize
force-pushed
the
check-quantized
branch
from
b3f0f13 to
c9f1e07
Compare
JMMackenzie
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
--checkflag to take effect when compressing an index.Note that tests for scorers other than BM25 are missing as they are currently failing. It needs further investigation.