-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar not showing tabs #2200
Comments
I have also seen this happen after browser restarts. It started about last week, if I remember correctly. I have experienced it with Firefox 66.0 and Firefox 66.0.1 so far. The sidebar only shows a circle moving left and right, and below that a progress bar that gets stuck at about 10 % or 20 %. No tabs are shown. I tried to disable and re-enable caching in the addon preferences, but that did not help. I was able to work around the issue by disabling and re-enabling the addon. After it is re-enabled, it shows the moving circle and the progress bar, but then the progress bar slowly fills. When it reaches 100 %, the tab structure appears in the sidebar, with most subtrees expanded. (Note: the progress bar does not actually show percentages; I guessed the numbers.) |
I have this bug sometimes. It seems to happen when I restart Firefox also |
I use Firefox across a Win10 laptop, linux desktop and MacBook pro with a shared firefox profile. As of the 66 firefox update on all three, the MacBook version refuses to show TST, I only get the moving circle and 10% progress bar. No amount of on/off or restarts seems to want to fix it. Both linux and Win10 systems still work just fine |
Of course having posted the previous update I tried again; disabled TST, restarted firefox, enabled TST and now it works again -- although as it started it "mostly" reloaded the previous configuration but somewhat arbitrarily deleted five or six tabs of about 30 |
I have the same problem. Except, when I disable it and re-enable it, it still doesn't work. It's useless like this. And I really like/depend of this extension. Any time frame on when it will be fixed? (Using FF 66.0.1 on Ubuntu 18.04) |
Could you collect detailed startup reports? They may help debugging:
By the way, currently a reconstruction task is in progress at #2139 so the problem may disappear on the latest development build. |
Background Page (master process)gMetricsData.toString() SidebargMetricsData.toString() |
I loaded the latest and, while it did load the TST and the tabs properly, I did get an error message, "Reading manifest: Error processing variable_color_icons: An unexpected property was found in the WebExtension manifest." |
Actually I have been using the latest dev build for a few days and it comes up when I start FF, and seems to work fine now. Thanks! EDIT: Well, I spoke too soon. I removed the tabs at the top (userChrome.css) and restarted FF but the tabs didn't show up in TST. |
And ... now it works again. ???? |
I also have been having this issue for maybe the past month. Can't recall what Firefox version it started under. I can attest that it has nothing to do with Windows version as this workstation was running Win 8.1 last week and I upgraded it to Win10 1803 a few days ago and it still occurs. Just happened this morning. in my case, restarting FF usually fixes it. |
I still need more help like #2200 (comment) with steps I wrote at #2200 (comment) because each case may be triggered with different reasons. |
Roger that. I enabled debugging. Next time it happens I'll grab it. Thx |
I have the same annoying problem. Here is some data: Background page:
Sidebar:
I'm using the current version, 3.0.4. |
@fdw Thanks, the log means that TST is hanging up while session restoration. On TST 3.0.5 I've added some more error handling and log messages, so when you see any error messages like "fatal error", please post it here. |
I have updated the addon and managed to run into the same problem again (yay, I guess ;)). However, I have no gMetricsData for sidebar:
|
Actually, this may not be the same issue at all. I use this snippet to hide the scroll bar (which I got from the Wiki and adjusted with a fix for it now working):
The line So it appears my problem is with my fix to the snippet, which now no longer works and makes the tab labels disappear (probably it pushes them too far out). But the original snippet doesn't seem to work either (it has no effect at all for me). I'm observing this in FF 66.0.2 on Ubuntu 16.04 with TST 3.0.5. |
@fdw Thanks! Hmm, I cannot imagine why TST failed to read the structure info on your environment with the message
Anyway, if you didn't see any "fatal error" log, these messages indicate that TST's initialization process worked as expected around the background page. Does the blank sidebar still there? Then, could you paste the result of |
Yes, the sidebar was only showing the loading. Now, I thought it might be interesting to give you also information if everything works: Background, working
Sidebar, working
After some restarts, I managed to make it hang again (only the progress bar and the spinner showing): Background, hanging
Sidebar, hanging
Finally, I closed the sidebar with Background, fixed
Sidebar, fixed
There were no "fatal errors" anywhere. |
Okay, here's my dump. This is a Win 10 Pro 1803 system. Latest version of TreeStyle Tabs (v3.0.5). This is my gaming PC. It happens more often on this PC than my workstation. Maybe because the workstation stays on all the time and the gaming PC is turned off when not in use? Both PCs are practically identical (same mobo, both Win10 Pro 1803). The gaming PC's Mozilla user profile was copied from the workstation so it's possible this one "inherited" the issue from the other PC. Could not map contract ID '@mozilla.org/widget/printdialog-service;1' to CID {06beec76-a183-4d9f-85dd-085f26da565a} because no implementation of the CID is registered. gMetricsData.toString() |
Some more background if it helps: Both PCs this occurs on have the primary user configured as a Limited User (I don't run as admin on any PC except my server). Only other Firefox add-ons installed are: uBlock Origin & New Tab Override. |
UPDATE: I just wanted to report back that since the last update, I haven't had the problem recur. Thx! |
UPDATE 2: Aaand the very next day it started happening again. Weird. Been working fine for almost 2 weeks, but both PCs are doing this again. Disabling the add-on and turning it back on clears it. Been too distracted to do a dump, but I'll try next time it happens. |
Ok, I confirmed I have the recent 3.0.8 update released yesterday and that seems to be when this started. |
Okay here's a dump. Hope this helps. I get the throbber going left and right with the green progress bar at about 15% just about every time I open FF now since yesterday. Thx: INSPECT BACKGROUND PAGE (master process): gMetricsData.toString() INSPECT SIDEBAR: gMetricsData.toString() |
Rolled back to 3.0.7 and it works fine. |
@FlyingPenguinOFC Thank you for more logs. Your logs says that the sidebar page was initialized at first and failed to receive an important message from the background page. I think it is a timing issue, and I hope that the commit e61a1a9 should fix it. Could you try the latest development build? |
Thx for the reply! I'll need some instructions on how to download and install the latest dev build. I'm an IT guy, but I have no idea how to download and install it from Github. Thx. |
@FlyingPenguinOFC There is a documentation: https://github.com/piroor/treestyletab#development-builds |
Okay, I installed 3.0.8.9048 in the Nighly Firefox because there's no way to install it in the regular Firefox as any temporary add-on is flushed on restart, and this only happens when Firefox opens. In the Nightly Firefox the same thing happens: most of the time the throbber stalls. Disabling and restarting the addon clears the problem. I have had no problem at all on the regular Firefox using version 3.07. The throbber hasn't gotten stuck at all. I am one of those people who always shuts down Firefox when I walk away from the PC so Firefox does get closed and re-opened several dozens of times a day. Here's the dump of 3.0.8.9048 running on the Nightly Firefox, immediately after opening the browser and with the throbber stuck: background page (master process): gMetricsData.toString() inspect the sidebar gMetricsData.toString() |
Hmm...I think I need to see all debug logs on your case. Could you collect complete debug logs? Please activate the debug mode and activate all detailed logs to get them. |
Thank you for all your work. After enabling debugging as explained in your FAQ under "How to collect debug logs of TST?", then restarting, and the throbber gets stuck: In the error and warnings list is this: Error: Attempt to postMessage on disconnected port sidebar-connection.js:88:12 When I run "log.logs.join('\n')"from the console, this it the output: "tst: Mon Apr 29 2019 18:38:04 GMT-0400 (Eastern Daylight Time) background/browser-action-menu: create: ({id:\"browserActionItem:0\", title:\"Appearance\", type:\"normal\", contexts:[\"browser_action\"], parentId:null})
tst: Mon Apr 29 2019 18:38:04 GMT-0400 (Eastern Daylight Time) background/browser-action-menu: create: ({id:"browserActionItem:0:0", title:"Style of contents for the sidebar position", type:"normal", contexts:["browser_action"], parentId:"browserActionItem:0"}) |
@FlyingPenguinOFC Thanks, but sadly logs were overflowed with lines from unrelated modules... I think we need to suppress too noisy modules. I've narrowed down log modules related to this problem: |
Ok, this is a huge dump so I'm dragging and dropping a text file in here. Let me know if you can't open it. This was on Firefox Nightly with the new 3.0.9 version you released today. Throbber still gets stuck. Thanks. |
@FlyingPenguinOFC Thanks again. I've read your log and realized that the master process and the sidebar are initialized at just same time.
However, the resolution of these timestamp is too low, so I've introduced some changes to output timestamp with more effective resolution. Could you try again with the latest development build?: https://github.com/piroor/treestyletab/blob/master/README.md#development-builds |
Here you go: |
@FlyingPenguinOFC Thanks, I think I successfully understand what's happen on your environment.
These events were expected to happen in this order, but actually the first one happens after the second one on your environment. This causes the stacking. I've introduced some changes to support such cases. I hope that the new development build should work correctly, so could you try it again? |
Seems to be working. I have 3.0.9.9070 running on Firefox Nighlty. Restarted a dozen times and no problems. When you release this to the public I'll install it in my regular Firefox. Thx. |
3.0.10 seems to be working fine for me on regular release Firefox. Thanks! |
The same thing appears to be happening again on nightly. Environment
|
No description provided.
The text was updated successfully, but these errors were encountered: