React Native client for the bot ready example. #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipi87
changed the title
|
I'm going to defer this review to @kompfner since RN is out of my comfort zone. |
kompfner
reviewed
Feb 18, 2025
| @@ -0,0 +1 @@ | |||
| 18.18 | |||
There was a problem hiding this comment.
Should we use the current active lts node version (22)? Or at least the maintenance lts version (20)? 18 is on its last legs
kompfner
reviewed
Feb 18, 2025
| if (evt.track.kind === "audio" && evt.participant.local === false) { | ||
| handleEventToConsole(evt) | ||
| log("Sending the message that will trigger the bot to play the audio.") | ||
| callObject.sendAppMessage("playable") |
There was a problem hiding this comment.
so in RN just waiting for the track-started event is sufficient? cool 👍
There was a problem hiding this comment.
It is because in the server we are still sending some silence. So, triggering it at this point is enough. 🙂
kompfner
approved these changes
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to create a react native client for the bot ready example.