Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Initialisms are not capitalized consistently #417

Closed
maxhawkins opened this issue Feb 18, 2019 · 1 comment
Closed

API: Initialisms are not capitalized consistently #417

maxhawkins opened this issue Feb 18, 2019 · 1 comment
Assignees
@maxhawkins
Milestone
2.0.0 (Spear of D...

Comments

@maxhawkins
Copy link
Contributor

In Go, the convention is for initialisms to be capitalized.

This isn't followed consistently in our codebase. For instance, Ssrc should be SSRC.
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename Ssrc -> SSRC
60290a2 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename Sdp -> SDP
3ede88b 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename MacKey -> MACKey
9b288a2 
Relates to #417
@maxhawkins maxhawkins mentioned this issue Feb 18, 2019
Merged
@Sean-Der Sean-Der added this to the 2.0.0 (Spear of Destiny) milestone Feb 18, 2019
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename Ssrc -> SSRC
7fb30ce 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename Sdp -> SDP
47083c3 
Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename MacKey -> MACKey
8be97a2 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Upgrade to pions/sdp v2
fb694fa 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Upgrade to pions/sdp v2
0d92c8c 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Upgrade to pions/sdp v2
9fcefeb 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename Ssrc -> SSRC
7551cbb 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename Sdp -> SDP
93c961a 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Rename MacKey -> MACKey
31ddd5a 
Relates to #417
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Upgrade to pions/sdp v2
d55261e 
Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename Ssrc -> SSRC
c6592e6 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename Sdp -> SDP
9d88f7c 
Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Rename MacKey -> MACKey
6567fca 
Relates to #417
Sean-Der pushed a commit that referenced this issue Feb 18, 2019
@maxhawkins @Sean-Der
Upgrade to pions/sdp v2
9cba54c 
Relates to #417
@Sean-Der
Copy link
Member

Fixed with 9cba54c

Nice work @maxhawkins

Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins @Sean-Der
Rename Ssrc -> SSRC
71872b8 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to pion#417
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins @Sean-Der
Rename Sdp -> SDP
167718d 
Relates to pion#417
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins @Sean-Der
Rename MacKey -> MACKey
c6ed90f 
Relates to pion#417
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins @Sean-Der
Upgrade to pions/sdp v2
277cc52 
Relates to pion#417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxhawkins maxhawkins

Labels
None yet
Milestone
2.0.0 (Spear of Destiny)
Development

No branches or pull requests
2 participants
@maxhawkins @Sean-Der