Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order dependent test in server_test.go #437

Closed
wants to merge 1 commit into from

Conversation

jaystenmark
Copy link
Contributor

go test -shuffle=1738872331488754809 now passes

Description

Closes a dangling connection to ensure all goroutines created in test are stopped.

Reference issue

Fixes #436

`go test -shuffle=1738872331488754809` now passes
@Sean-Der
Copy link
Member

Thank you! I bet this is massively a problem in pion/webrtc

should we shuffle in CI?

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (31282d5) to head (62e6dbd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   66.37%   66.14%   -0.23%     
==========================================
  Files          43       43              
  Lines        3084     3084              
==========================================
- Hits         2047     2040       -7     
- Misses        871      877       +6     
- Partials      166      167       +1     
Flag Coverage Δ
go 66.14% <ø> (-0.23%) ⬇️
wasm 26.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der closed this Feb 14, 2025
@Sean-Der
Copy link
Member

I am going to re-open these PRs. CI was broken, and will be working on new PR.

sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Order dependent test in server_test.go
2 participants