Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ufrag extension #759

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Include ufrag extension #759

merged 1 commit into from
Jan 31, 2025

Conversation

JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Jan 30, 2025

Description

Include ufrag extension in the ICE candidates generated by the ICE agent

Reference issue

Fixes #757
based on: #758

@JoeTurki JoeTurki force-pushed the impr/include-ufrag-extension branch 8 times, most recently from e3186e4 to 39bfb5f Compare January 30, 2025 09:28
Include ufrag extension in the ICE candidates generated by the ICE agent
@JoeTurki JoeTurki force-pushed the impr/include-ufrag-extension branch from 39bfb5f to d21ae5e Compare January 31, 2025 05:42
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (141df5a) to head (d21ae5e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
agent.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   78.63%   78.66%   +0.03%     
==========================================
  Files          41       41              
  Lines        5358     5367       +9     
==========================================
+ Hits         4213     4222       +9     
  Misses        915      915              
  Partials      230      230              
Flag Coverage Δ
go 78.66% <66.66%> (+0.03%) ⬆️
wasm 27.42% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki marked this pull request as ready for review January 31, 2025 05:45
@JoeTurki JoeTurki merged commit d21ae5e into master Jan 31, 2025
14 of 15 checks passed
@JoeTurki JoeTurki deleted the impr/include-ufrag-extension branch January 31, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Include ufrag Extension with Generated ICE Candidates
2 participants