Add message key/value size metric in the processor #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`processor.message.key.size.bytes` `processor.message.value.size.bytes` Also added unit tests to processors for non keyed messages.
ambud
approved these changes
Aug 21, 2020
kabochya
pushed a commit
to kabochya/singer
that referenced
this pull request
Feb 17, 2021
Summary: pinterest#80 pinterest#81 pinterest#82 Test Plan: on devapp mvn clean package Reviewers: vhashemian, O913 LoggingSOX, ambudsharma Reviewed By: vhashemian, O913 LoggingSOX JIRA Issue(s): LP-4635 Differential Revision: https://phabricator.pinadmin.com/D605941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processor.message.key.size.bytesprocessor.message.value.size.bytesAlso added unit tests to processors for non keyed messages.