ui: Add Query Nagging for Sampling #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into query-nagging
…into query-nagging
zhangvi7
commented
Jun 25, 2024
czgu
reviewed
Jun 26, 2024
querybook/webapp/components/DataDocQueryCell/DataDocQueryCell.tsx
Outdated
Show resolved
Hide resolved
zhangvi7
commented
Jun 27, 2024
| docId={docId} | ||
| key={selectedExecution.id} | ||
| changeCellContext={changeCellContext} | ||
| onSamplingInfoClick={onSamplingInfoClick} |
There was a problem hiding this comment.
Only change in this file was passing 2 props here, rest is auto formatted changes
|
jczhong84
reviewed
Jun 27, 2024
jczhong84
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During query runs, if it is taking more than 10 seconds and the query could be sampled, we show a suggestion to users that they can cancel their current query and run a sampled version instead.
Test Plan