fix: some small changes of ai assistant #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jczhong84
commented
Jun 28, 2023
•
jczhong84
commented
- use text area instead of input for the text2sql question to support multiple lines
- add another button of "apply and run" to run the query directly
- generate a title along with the query generation and query cell title will be updated once applied
- updated the title generation prompt. Seems it will not add quotes and final period with gpt3.5 anymore.
- updated the text2sql prompt to include the question being asked in a comment of the query
- pass query cell id instead of the query for title generation
- log cell id for title generation and auto fix
czgu
reviewed
Jun 28, 2023
querybook/server/lib/ai_assistant/assistants/openai_assistant.py
Outdated
Show resolved
Hide resolved
czgu
reviewed
Jun 28, 2023
| @@ -24,136 +24,155 @@ interface IProps { | |||
| isQueryCollapsed: boolean; | |||
|
|
|||
| changeCellContext?: (context: string) => void; | |||
| onChangeFromAI?: (query: string, run: boolean) => void; | |||
There was a problem hiding this comment.
why don't we just use changeCellContext but also add an optional parameter to run?
| @@ -45,7 +46,10 @@ export const QueryCellTitle: React.FC<IQueryCellTitleProps> = ({ | |||
| } | |||
| }, [streamStatus, title]); | |||
|
|
|||
| const handleTitleGenerationClick = useCallback(() => { | |||
| const handleTitleGenerationClick = useCallback(async () => { | |||
There was a problem hiding this comment.
use forceSaveDataDoc method instead of calling api directly
czgu
approved these changes
Jun 29, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* fix: some small changes of ai assistant * fix prompt template return type * comments * force save cell * remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.