Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add get_schema_location to metastore loader #1214

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix: add get_schema_location to metastore loader #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions querybook/server/lib/metastore/base_metastore_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,10 @@ def get_data_element(self, data_element_name: str) -> Optional[DataElementTuple]
"""Override this to get data element by name"""
pass

def get_schema_location(self, schema_name: str) -> str:
"""Get schema location, used by table uploader"""
pass

@abstractclassmethod
def get_metastore_params_template(self) -> AllFormField:
"""Override this to get the form field required for the metastore
Expand Down
3 changes: 3 additions & 0 deletions querybook/server/lib/metastore/loaders/hive_metastore_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ def get_partitions(
self.hmc, schema_name, table_name, conditions
)

def get_schema_location(self, schema_name: str) -> str:
return self.hmc.get_database(schema_name).locationUri

def _get_hmc(self, metastore_dict):
return HiveMetastoreClient(
hmss_ro_addrs=metastore_dict["metastore_params"]["hms_connection"]
Expand Down
17 changes: 8 additions & 9 deletions querybook/server/lib/table_upload/exporter/s3_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,17 @@ def destination_s3_root(self, session=None) -> str:
return sanitize_s3_url_with_trailing_slash(s3_path) + schema_name + "/"

if self._exporter_config.get("use_schema_location", False):
# Defer import since this is only needed for this option
from lib.metastore.loaders.hive_metastore_loader import HMSMetastoreLoader

query_engine = get_query_engine_by_id(self._engine_id, session=session)
metastore: HMSMetastoreLoader = get_metastore_loader(
query_engine.metastore_id, session=session
metastore = get_metastore_loader(query_engine.metastore_id, session=session)

if metastore is None:
raise Exception("Invalid metastore")

schema_location_uri = metastore.get_schema_location(
self._table_config["schema_name"]
)
if metastore is None or not isinstance(metastore, HMSMetastoreLoader):
if not schema_location_uri:
raise Exception("Invalid metastore to use use_schema_location option")
schema_location_uri = metastore.hmc.get_database(
self._table_config["schema_name"]
).locationUri

return sanitize_s3_url_with_trailing_slash(schema_location_uri)

Expand Down