fix: some bug fix related to tag and data element #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Mar 17, 2023
| for row in associations: | ||
| data_element["type"] = row.type.value | ||
| data_element[row.property_name] = ( | ||
| row.data_element.to_dict() if row.data_element else row.primitive_type |
There was a problem hiding this comment.
don't serialize it here. Let it be serialized automatically when returning
There was a problem hiding this comment.
api json encoder wont do automatic serialization for nested objects.
| }) => { | ||
| const { data: tableColumnStats } = useResource( |
There was a problem hiding this comment.
since we don't get tags, data elements, and stats individually anymore, can you remove the api and resource?
There was a problem hiding this comment.
actually there are 3 /column/stats apis, two of them are also not used today. should we remove all of them?
@register("/column/stats/<int:column_id>/", methods=["GET"])
@register("/column/stats/<metastore_name>/", methods=["POST"])
@register("/column/stats/", methods=["POST"])
There was a problem hiding this comment.
oh yeah lets remove all of them then
| @@ -116,6 +119,9 @@ export interface IDataColumn { | |||
| name: string; | |||
| table_id: number; | |||
| type: string; | |||
| stats?: ITableColumnStats[]; | |||
There was a problem hiding this comment.
instead of stats?, can you separate the type out to be IDetailedDataColumn extends IDataColumn?
czgu
previously approved these changes
Mar 17, 2023
czgu
approved these changes
Mar 17, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* fix: some tag ui bugs * comments * remove column stats api
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* fix: some tag ui bugs * comments * remove column stats api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some bug fixes
Also removed the expand/collapse toggle button and move the column name before the column type
