Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic authorization into trino client #829

Closed
a-pertsev opened this issue Apr 11, 2022 · 1 comment · Fixed by #1315 · May be fixed by #841
Closed

Add basic authorization into trino client #829

a-pertsev opened this issue Apr 11, 2022 · 1 comment · Fixed by #1315 · May be fixed by #841

Comments

@a-pertsev
Copy link
Contributor

Probably trino client should use username/password authorization, like presto client do
@a-pertsev a-pertsev mentioned this issue Apr 14, 2022
Open
@baumandm
Copy link
Contributor

baumandm commented Jul 13, 2022 •
edited
Loading

We've ran into the same issue authenticating to our Trino clusters and did a similar patch. I've tested #841 and it works well.

rbb17 added a commit to rbb17/querybook that referenced this issue Aug 22, 2023
@rbb17
Add Username + Password Authentication for Trino Client (fixes pinter…
d229466 
…est#829)
@rbb17 rbb17 mentioned this issue Aug 22, 2023
Merged
czgu pushed a commit that referenced this issue Aug 25, 2023
@rbb17
Add Username + Password Authentication for Trino Client (fixes #829) (#…
814781e 
…1315)

* Add Username + Password Authentication for Trino Client (fixes #829)

* Making trino authentication backwards compatible

* Removing duplicate connection code
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this issue Jan 3, 2024
@rbb17 @aidenprice
Add Username + Password Authentication for Trino Client (fixes pinter…
3f212ed 
…est#829) (pinterest#1315)

* Add Username + Password Authentication for Trino Client (fixes pinterest#829)

* Making trino authentication backwards compatible

* Removing duplicate connection code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@a-pertsev @baumandm