Add foreign key name in the latest migration (#358)

pinterest · Dec 17, 2020 · bc626e3 · bc626e3
1 parent 978b513
commit bc626e3
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 15 deletions.
diff --git a/datahub/migrations/versions/b8a9e3e18bcc_add_more_cascade_relationship.py b/datahub/migrations/versions/b8a9e3e18bcc_add_more_cascade_relationship.py
@@ -10,29 +10,64 @@
 
 
 # revision identifiers, used by Alembic.
-revision = 'b8a9e3e18bcc'
-down_revision = '7d24ddb3edb9'
+revision = "b8a9e3e18bcc"
+down_revision = "7d24ddb3edb9"
 branch_labels = None
 depends_on = None
 
 
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_constraint('data_doc_editor_ibfk_1', 'data_doc_editor', type_='foreignkey')
-    op.create_foreign_key(None, 'data_doc_editor', 'data_doc', ['data_doc_id'], ['id'], ondelete='CASCADE')
-    op.drop_constraint('job_metadata_metastore_fk', 'data_job_metadata', type_='foreignkey')
-    op.create_foreign_key('job_metadata_metastore_fk', 'data_job_metadata', 'query_metastore', ['metastore_id'], ['id'], ondelete='CASCADE')
-    op.drop_constraint('data_schema_ibfk_1', 'data_schema', type_='foreignkey')
-    op.create_foreign_key(None, 'data_schema', 'query_metastore', ['metastore_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint("data_doc_editor_ibfk_1", "data_doc_editor", type_="foreignkey")
+    op.create_foreign_key(
+        "data_doc_editor_ibfk_3",
+        "data_doc_editor",
+        "data_doc",
+        ["data_doc_id"],
+        ["id"],
+        ondelete="CASCADE",
+    )
+    op.drop_constraint(
+        "job_metadata_metastore_fk", "data_job_metadata", type_="foreignkey"
+    )
+    op.create_foreign_key(
+        "job_metadata_metastore_fk",
+        "data_job_metadata",
+        "query_metastore",
+        ["metastore_id"],
+        ["id"],
+        ondelete="CASCADE",
+    )
+    op.drop_constraint("data_schema_ibfk_1", "data_schema", type_="foreignkey")
+    op.create_foreign_key(
+        "data_schema_ibfk_1",
+        "data_schema",
+        "query_metastore",
+        ["metastore_id"],
+        ["id"],
+        ondelete="CASCADE",
+    )
     # ### end Alembic commands ###
 
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_constraint(None, 'data_schema', type_='foreignkey')
-    op.create_foreign_key('data_schema_ibfk_1', 'data_schema', 'query_metastore', ['metastore_id'], ['id'])
-    op.drop_constraint('job_metadata_metastore_fk', 'data_job_metadata', type_='foreignkey')
-    op.create_foreign_key('job_metadata_metastore_fk', 'data_job_metadata', 'query_metastore', ['metastore_id'], ['id'])
-    op.drop_constraint(None, 'data_doc_editor', type_='foreignkey')
-    op.create_foreign_key('data_doc_editor_ibfk_1', 'data_doc_editor', 'data_doc', ['data_doc_id'], ['id'])
+    op.drop_constraint("data_schema_ibfk_1", "data_schema", type_="foreignkey")
+    op.create_foreign_key(
+        "data_schema_ibfk_1", "data_schema", "query_metastore", ["metastore_id"], ["id"]
+    )
+    op.drop_constraint(
+        "job_metadata_metastore_fk", "data_job_metadata", type_="foreignkey"
+    )
+    op.create_foreign_key(
+        "job_metadata_metastore_fk",
+        "data_job_metadata",
+        "query_metastore",
+        ["metastore_id"],
+        ["id"],
+    )
+    op.drop_constraint("data_doc_editor_ibfk_3", "data_doc_editor", type_="foreignkey")
+    op.create_foreign_key(
+        "data_doc_editor_ibfk_1", "data_doc_editor", "data_doc", ["data_doc_id"], ["id"]
+    )
     # ### end Alembic commands ###
diff --git a/requirements/base.txt b/requirements/base.txt
@@ -24,7 +24,7 @@ redis==3.5.2
 gevent==20.6.2
 greenlet==0.4.16  # 0.4.17 update causes UWSGI to break
 
-alembic==1.0.3
+alembic==1.4.3
 
 gevent-websocket==0.10.1
 flask-socketio==4.2.0