Add gets_many to HashClient. #137
Conversation
|
@nichochar I raised the issue that HashClient is missing gets_many here #136. Could you please review my PR for adding this feature? Thanks. |
pymemcache/client/hash.py
Outdated
| @@ -301,6 +307,11 @@ def get_many(self, keys, *args, **kwargs): | |||
| def gets(self, key, *args, **kwargs): | |||
| return self._run_cmd('gets', key, None, *args, **kwargs) | |||
|
|
|||
| def gets_many(self, keys, *args, **kwargs): | |||
| return self.get_many(keys, True, *args, **kwargs) | |||
There was a problem hiding this comment.
can we write the kwarg explicitely here please? gets=True
|
This looks good, a part from a quick style change. The travis failure I believe is unrelated, due to some issue with gevent 1.1 and python 2.6... Travis always gives us a hard time. I will look into this and try and fix it so you can rebase and we can go ahead and merge your change. |
|
@nichochar Thanks for reviewing this PR. I have made the |
|
@nichochar Thank you for merging my PR. Could you kindly update the PyPI package? Let me know if you want me to do the release steps up to uploading the packages step from https://github.com/pinterest/pymemcache/wiki/Release-Checklist |
|
Yep, the pypi package is updated now, |
No description provided.