Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ktlint CLI could skip checking some of explicetly passed files. #984

Merged

Conversation

Tapchicoma
Copy link
Collaborator

@Tapchicoma Tapchicoma commented Nov 30, 2020

Bug is in external dependency klob. Seems it is unmaintined, probably worth to think about alternatives 🤔

Added a workaround for now.

Fixes #942

Bug is in external dependency klob. Add a workaround for now.

Signed-off-by: Yahor Berdnikau <[email protected]>
@Tapchicoma Tapchicoma force-pushed the 942/fix-ktlint-doesnot-lint-some-files branch 2 times, most recently from a4ce57b to bcf4edb Compare December 3, 2020 20:49
@Tapchicoma Tapchicoma merged commit 0b8593f into pinterest:master Dec 4, 2020
@Tapchicoma Tapchicoma deleted the 942/fix-ktlint-doesnot-lint-some-files branch December 4, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint doesn't report issues for all files, if path of one file is a subpath of another
1 participant