Support absolute paths for globs #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly expand tilde in globs * Support unescaped backslashes on Windows * Support absolute paths
* Updated CHANGELOG.md
|
This should be useful. Finally we will make ktlint great again with absolute paths |
* Fix compilation on Java 8
* Fix logic with tilde
romtsn
pushed a commit
to paul-dingemans/ktlint
that referenced
this pull request
Aug 8, 2021
* Support absolute paths for globs * Correctly expand tilde in globs * Support unescaped backslashes on Windows * Support absolute paths * Support absolute paths for globs * Updated CHANGELOG.md * Support absolute paths for globs * Fix compilation on Java 8 * Support absolute paths for globs * Fix logic with tilde Co-authored-by: Sha Sha Chu <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PathMatcher)This closes #1131 and also two more minor issues I've discovered along the way.
I found out that
PathMatcherworks OK with absolute paths in globs, and based on discussion in #1131 decided that it's no more a design decision to support only relative paths. So I attempted to implement this fix. Will gladly hear any feedback.Checklist
CHANGELOG.mdis updated