SPM support #571
Merged
SPM support #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Carthage and SPM jobs
|
@3a4oT Looks good to me! Thank you for putting up this PR! |
garrettmoon
approved these changes
Oct 6, 2020
|
@garrettmoon thanks! Can you please review follow up commits #573? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is POC.
Depends on Added SPM support PINCache#283.
Use only for SPM https://github.com/SDWebImage/libwebp-Xcode -
libwebpwrapper. (submodule pointed to libwebp GitHub mirror)The current
PINRemoteImagesource files layout is hard to adopt for SPM. To allow build with SPM I added theincludefolder and moved all public headers to it.SPM test target is omitted since currently, PINRemoteImageTests contains mixed sources (Objective-C and Swift) which are not supported by SPM. Tests sources should be restructured in the way we could make two separate test targets for Swift sources and Objective-C. As far as we can perform testing using the Xcode project to run tests I think it's fine to leave it as is.
Carthage doesn't support Xcode 12 yet. Pinned to Xcode 11.7