Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposure didCompleteTask:withError: delegate method of protocol PINURLSessionManagerDelegate #519

Merged
merged 7 commits into from
Nov 9, 2019
Merged

Exposure didCompleteTask:withError: delegate method of protocol PINURLSessionManagerDelegate #519

merged 7 commits into from
Nov 9, 2019

Conversation

zhongwuzw
Copy link
Contributor

After we exposure didCompleteTask:withError: method, user can have a global monitor that task finished success or fail.

@bolsinga
Copy link
Contributor

Thanks in advance for the test case.

@ghost
Copy link

ghost commented Jul 10, 2019

🚫 CI failed with log

@ghost
Copy link

ghost commented Jul 12, 2019

🚫 CI failed with log

william93609614
william93609614 suggested changes Nov 7, 2019
View reviewed changes
Copy link

@william93609614 william93609614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect app get feedback Pinterest

@ernestmama ernestmama merged commit 5e51b81 into pinterest:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william93609614 william93609614 william93609614 requested changes

@ernestmama ernestmama ernestmama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhongwuzw @bolsinga @ernestmama @william93609614 @garrettmoon