Fixes AnimatedImageView designated inilializer not work #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test. |
garrettmoon
reviewed
Jul 9, 2019
| @@ -61,6 +61,31 @@ - (void)commonInit:(PINCachedAnimatedImage *)animatedImage | |||
| { | |||
| _animatedImage = animatedImage; | |||
| _animatedImageRunLoopMode = NSRunLoopCommonModes; | |||
|
|
|||
| [self initializeAnimatedImage:animatedImage]; | |||
There was a problem hiding this comment.
Can you add a nil check here and make mark initializeAnimatedImage: as taking a non null animatedImage?
|
Looks like the right fix to me! @DreamingInBinary do you mind testing to make sure this addresses your issue? |
|
Added test. |
|
Thanks for adding a test! |
|
Mind adding an entry to CHANGELOG.md for this one? |
|
Changelog added, I'll add changelog for all my PRs. :) |
|
🚫 CI failed with log |
|
Mind rebasing against master? I think I fixed a flakey test. |
garrettmoon
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497 .