Add pin animated image view #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
garrettmoon
commented
Apr 24, 2018
garrettmoon
commented
- Add support for GIFs (natively) and animated WebP
|
🚫 CI failed with log |
Adlai-Holler
approved these changes
Apr 25, 2018
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| imageView.pin_setImage(from: URL(string: "https://i.pinimg.com/originals/f5/23/f1/f523f141646b613f78566ba964208990.gif")) |
There was a problem hiding this comment.
Wonder why this example uses viewWillAppear: and the other uses viewDidLoad?
| </imageView> | ||
| </subviews> | ||
| <animations/> | ||
| <color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/> | ||
| <color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/> |
There was a problem hiding this comment.
These storyboards seem nice 😍
| - (void)viewDidAppear:(BOOL)animated | ||
| { | ||
| [super viewDidAppear:animated]; | ||
| [self.animatedImageView pin_setImageFromURL:[NSURL URLWithString:@"https://i.pinimg.com/originals/f5/23/f1/f523f141646b613f78566ba964208990.gif"]]; |
There was a problem hiding this comment.
Now we're doing viewDidAppear: wat
There was a problem hiding this comment.
😁 I was just copying the other view controllers in each project. This is what happens when each example project is built by someone else…
There was a problem hiding this comment.
But did appear seems decidedly wrong and so does load…
| if (_animatedImage) { | ||
| return _frameImage; | ||
| } else if ([super image]) { | ||
| return (CGImageRef)CFAutorelease(CFRetain([[super image] CGImage])); |
There was a problem hiding this comment.
Nit: worth eliminating the multiple [super image] calls?
| { | ||
| PINAssertMain(); | ||
| _frameInterval = frameInterval; | ||
| } |
There was a problem hiding this comment.
Gotta have that assert :)
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.