Code review updates

Added a comment
pinterest · Jun 11, 2018 · 4dca22a · 4dca22a
1 parent b1ae25f
commit 4dca22a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/Source/Classes/PINRemoteImageManager.m b/Source/Classes/PINRemoteImageManager.m
@@ -826,6 +826,11 @@ - (void)downloadImageWithURL:(NSURL *)url
                                 NSArray<NSString *> *split = [trimmed componentsSeparatedByString:@"max-age="];
                                 if ([split count] == 2)
                                 {
+                                    // if the max-age provided is invalid (does not parse into an
+                                    // int), we wind up with 0 which will be treated as do-not-cache.
+                                    // This is the RFC defined behavior for a malformed "expires" header,
+                                    // and while I cannot find any explicit instruction of how to behave
+                                    // with a malformed "max-age" header, it seems like a reasonable approach.
                                     maxAge = @([split[1] integerValue]);
                                 }
                             }