Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed watchos linting errors #69

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

benasher44
Copy link
Contributor

  • travis.yaml now runs pod lib lint
  • Fixed up build_tests.sh to work with recent xcode tools
  • Fixed some async-related test failures/flakes

This was referenced Feb 12, 2016
@garrettmoon
Copy link
Collaborator

@benasher44 looks like pod lib lint passes, but pod spec lint fails with the same error :(

@garrettmoon
Copy link
Collaborator

Ohhh, but it may be that it's because this isn't merged. Hold off on investigating.

@benasher44
Copy link
Contributor Author

@garrettmoon pod spec lint looks at the podspec, and downloads the code pointed to by the spec, and then it does pod lib lint. Since the pod spec is still pointing at the failing tag, that's expected. Once this is merged, you'll need to update the tag. Then, it should pass.

@benasher44
Copy link
Contributor Author

This is also why I didn't have .travis.yaml do pod spec lint, since it'll just be looking at the same code every time :)

garrettmoon added a commit that referenced this pull request Feb 12, 2016
@garrettmoon garrettmoon merged commit 043cbc1 into pinterest:master Feb 12, 2016
@garrettmoon
Copy link
Collaborator

@benasher44 Thanks for doing this! Let's give it a go!

@garrettmoon
Copy link
Collaborator

Yeah, that makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants