Don't wait for all metadata to access any item from TTL cache #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects from TTL cache
…lizeDiskProperties]
garrettmoon
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
@wiseoldduck thanks for this contribution! This looks great. Mind addressing the minor comments and I'll merge?
Source/PINDiskCache.m
Outdated
| [self unlock]; | ||
| [self lockAndWaitForKnownState]; | ||
| if (!_diskStateKnown) { | ||
| if (_metadata[key]== nil) { |
There was a problem hiding this comment.
nit: add a space after ]
Source/PINDiskCache.m
Outdated
| } | ||
|
|
||
| - (void)_locked_initializeDiskPropertiesForFile:(NSURL *)fileURL fileKey:(NSString *)fileKey byteCount:(NSUInteger *)pByteCount { | ||
|
|
Source/PINDiskCache.m
Outdated
| return resourceKeys; | ||
| } | ||
|
|
||
| - (void)_locked_initializeDiskPropertiesForFile:(NSURL *)fileURL fileKey:(NSString *)fileKey byteCount:(NSUInteger *)pByteCount { |
There was a problem hiding this comment.
Would it be better to just return byteCount?
There was a problem hiding this comment.
Probably, although it's a little less obvious what it is
Whitespace, return fileSize from _locked_initializeDiskPropertiesForFile instead of taking a NSUInteger *param
|
Awesome, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.