fix: adds support for builds with cache #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Dec 3, 2021
| @@ -13,7 +13,9 @@ test('it should correctly generated all required pino files', (t) => { | |||
| const distFolder = resolve(__dirname, '../tmp/dist') | |||
|
|
|||
| t.teardown(() => { | |||
| spawnSync(`rm -rf ${distFolder}`) | |||
| spawnSync(`rm -rf ${distFolder}`, { | |||
| shell: true | |||
There was a problem hiding this comment.
That's because the command didn't locate correctly the rm executable so the tmp dir was not deleted.
test/cached-build.test.js
Outdated
| ) | ||
| } | ||
|
|
||
| test('it should correctly generated all required pino files', (t) => { |
There was a problem hiding this comment.
Suggested change
| test('it should correctly generated all required pino files', (t) => { | |
| test('it should correctly generate all required pino files', (t) => { |
There was a problem hiding this comment.
How is this testing that the output is being cached? It looks like it's testing that the output is generated correctly the second time you run the build, but not that the cache is being used. Am I missing something?
There was a problem hiding this comment.
The caching is enabled in the webpack configuration and I'm testing that nothing breaks when it is enabled.
I've renamed the test to make the intent more clear.
test/cached-build.test.js
Outdated
| }) | ||
| }) | ||
|
|
||
| runBuild(distFolder, () => { |
There was a problem hiding this comment.
add a check that this doesn't error
simoneb
approved these changes
Dec 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3