Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide wrapErrorSerializer to support custom error serializers #18

Merged
merged 1 commit into from
Apr 5, 2019
Merged

provide wrapErrorSerializer to support custom error serializers #18

merged 1 commit into from
Apr 5, 2019

Conversation

jstewmon
Copy link
Contributor

@jstewmon jstewmon commented Apr 4, 2019

No description provided.

mcollina
mcollina requested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the README?

@jstewmon jstewmon force-pushed the wrap-error-serializer branch from ffbef7a to f656442 Compare April 4, 2019 15:44
@jstewmon
Copy link
Contributor Author

jstewmon commented Apr 4, 2019

@mcollina I updated the docs and made another pass over the standard error serializer to include raw, so that custom serializers will have access to the original Error instance.

mcollina
mcollina approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners
Copy link
Member

jsumners commented Apr 5, 2019

I do not see the docs changes. Did you forget to push?

@jstewmon
provide wrapErrorSerializer to support custom error serializers
44caafb 
- define error object proto to include `raw`, so custom serializers
  have access to the original Error
- updated docs on wrapper utility functions to indicate value must be
  returned
@jstewmon jstewmon force-pushed the wrap-error-serializer branch from f656442 to 44caafb Compare April 5, 2019 12:28
@jstewmon
Copy link
Contributor Author

jstewmon commented Apr 5, 2019

🤦‍♂️ I must have flubbed my git add command yesterday. Changes to support raw and docs are actually pushed now.

@jstewmon jstewmon mentioned this pull request Apr 5, 2019
Merged
jsumners
jsumners approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit c8a8de9 into pinojs:master Apr 5, 2019
@jstewmon jstewmon deleted the wrap-error-serializer branch June 7, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@davidmarkclements davidmarkclements Awaiting requested review from davidmarkclements

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstewmon @jsumners @mcollina