Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error serialization compat #122

Merged
merged 2 commits into from
Dec 27, 2022
Merged

improve error serialization compat #122

merged 2 commits into from
Dec 27, 2022

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Dec 21, 2022

No description provided.

mcollina
mcollina approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

@ronag ronag requested a review from mcollina December 21, 2022 14:48
mcollina
mcollina approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jsumners December 24, 2022 16:13
@voxpelli
Copy link
Contributor

This will make it diverge from my upstream pony-cause module and would in that case cause problems with typing I believe.

Should we/I upstream this into pony-cause?

@ronag
Copy link
Contributor Author

ronag commented Dec 26, 2022

Sorry to bother. I need this for a deploy this week. Any chance for merge and release?

@jsumners jsumners merged commit 22ee50b into pinojs:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @voxpelli @mcollina @jsumners