implemented attribute 'download_file_list' #22
Conversation
…ownload in succeess
|
Unfortunately I could not create a working test due to my lack of knowledge :( . Could someone else do this and contact me as soon as this has happened? I would like to know how this could be made. |
|
Hello @grumpyshoe! Thank you for your PR. I will try to give it a look ASAP and create a working test. Cheers! |
|
Hi @bffcorreia, can you estimate when you will check and take over the PR? Greetings! |
|
Hopefully until the end of the week 🙂 |
|
Wow, this was something i was looking for! I'm now using the fork of @grumpyshoe and that works fantastic 👍 |
There was a problem hiding this comment.
Hi @grumpyshoe!
Sorry for my very late response. I'm currently very busy. I reviewed your code. Can you just check my comments?
Currently I don't have time to create tests for this feature but since there are people already using your fork, I think we can merge it and I will add the tests in the future.
Cheers and many thanks for your PR.
| @@ -160,6 +160,13 @@ run_tests_firebase_testlab( | |||
| <td>true</td> | |||
| </tr> | |||
|
|
|||
| <tr> | |||
| <td>download_file_list</td> | |||
| <td>A list of files that should be downloaded from the bucket or not, seperated by space. This is a additional parameter for 'download_results_from_firebase'</td> | |||
There was a problem hiding this comment.
Fix typo: "a additional parameter" to "an additional parameter"
| FastlaneCore::ConfigItem.new(key: :download_file_list, | ||
| env_name: "DOWNLOAD_FILE_LIST", | ||
| description: "A list of files that should be downloaded from the bucket or not, seperated by space. This is a additional parameter for 'download_results_from_firebase'. Default: empty string", | ||
| is_string: true, |
There was a problem hiding this comment.
Any reason to be a string? If this parameter is a list, it is probably better to use an Array. Can we change this?
| if params[:download_file_list] && !params[:download_file_list].empty? | ||
| UI.message("Get files at bucket...") | ||
|
|
||
| params[:download_results_from_firebase] = false |
|
Hi @MartyCatawiki! I reviewed the code now. I hope I can merge it soon :) Cheers |
|
Hi @grumpyshoe i was wondering if you can find some time to take a look at the comments of @bffcorreia. I would be really nice to have this PR added. 😃 |
|
HI @bffcorreia @MartyCatawiki , sorry for my late response, but I was quite busy too... Stay Tuned |
Implemented a new attribute 'download_file_list' to specify which file to download from bucket on success