Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: sync partition DDL even if upstream schema is not equal in optimistic mode #9789

Merged
merged 4 commits into from
Sep 25, 2023
Merged

dm: sync partition DDL even if upstream schema is not equal in optimistic mode #9789

merged 4 commits into from
Sep 25, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 22, 2023

What problem does this PR solve?

Issue Number: close #9788

What is changed and how it works?

  • if a DDL not effect table schema, sync it directly

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

Hi @GMHDBJD. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 22, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 22, 2023

/check-issue-triage-complete

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 22, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Sep 22, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 25, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 08:43:17.152879927 +0000 UTC m=+264386.871222138: ☑️ agreed by lance6716.
  • 2023-09-25 08:47:54.033461797 +0000 UTC m=+264663.751804014: ☑️ agreed by okJiang.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 25, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GMHDBJD,lance6716,okJiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 34896d5 into pingcap:master Sep 25, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9805.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 25, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9806.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 25, 2023
Merged
@D3Hunter
Copy link
Contributor

/cherry-pick release-6.5-20230626-v6.5.3

@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch release-6.5-20230626-v6.5.3: #9808.

In response to this:

/cherry-pick release-6.5-20230626-v6.5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 26, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2023
@ti-chi-bot
dm: sync partition DDL even if upstream schema is not equal in optimi…
7e90ede 
…stic mode (#9789) (#9808)

close #9788
GMHDBJD pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
dm: sync partition DDL even if upstream schema is not equal in optimi…
69e9d10 
…stic mode (#9789) (#9805)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2023
@ti-chi-bot
dm: sync partition DDL even if upstream schema is not equal in optimi…
5da4bdb 
…stic mode (#9789) (#9806)

close #9788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@okJiang okJiang okJiang approved these changes

Assignees
No one assigned
Labels
approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm can not sync partition DDL in optimistic shard mode
5 participants
@GMHDBJD @ti-chi-bot @D3Hunter @lance6716 @okJiang