sink(cdc): close table sinks when sink factory fails #9449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
asddongmen
approved these changes
Jul 31, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
CharlesCheung96
approved these changes
Jul 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest-required |
|
/test cdc-integration-mysql-test |
1 similar comment
|
/test cdc-integration-mysql-test |
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 1, 2023
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 2, 2023
close pingcap#9450 Signed-off-by: qupeng <[email protected]>
CharlesCheung96
pushed a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Aug 11, 2023
3AceShowHand
pushed a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9450
What is changed and how it works?
When sink factory fails we should close all table sinks and recycle their memory quota.
Currently it's performed in
table_sink_worker.go, but there could be a dead lock: a table task can only enter into table sink worker after acquires memory successfully. So if memory usage has reached the max limit, no table has chance to release its memory quota usage, except it gets removed.So this PR marks table sink as closed, and releases their memory usages after sink factory fails.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note