Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/orchestrator(ticdc): add timeout before remove capture #9445

Merged
merged 3 commits into from
Jul 31, 2023
Merged

pkg/orchestrator(ticdc): add timeout before remove capture #9445

merged 3 commits into from
Jul 31, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jul 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #9344

What is changed and how it works?

  1. Wait CaptureSessionTTL/2 seconds before removing a capture from GlobalReactorState.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix a bug that could result in double writes after a CDC node disconnects from etcd.`.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 27, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the add-ttl-when-capture-offline branch from c8721d3 to f119ff6 Compare July 28, 2023 01:59
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review July 28, 2023 01:59
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 02:01:27.007844145 +0000 UTC m=+64370.950192677: ☑️ agreed by nongfushanquan.
  • 2023-07-31 02:02:15.086589369 +0000 UTC m=+64419.028937925: ☑️ agreed by asddongmen.

@CharlesCheung96 CharlesCheung96 force-pushed the add-ttl-when-capture-offline branch from 3175ac3 to e036f5a Compare July 31, 2023 02:02
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
82710d1 
)
CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
fbc7bb8 
)
@CharlesCheung96
Copy link
Contributor Author

/retest

CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
7d7c200 
)
@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 63e0497 into pingcap:master Jul 31, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9455.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#9445
55551f7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9456.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#9445
339aa53 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9457.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 31, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#9445
5ab790a 
Signed-off-by: ti-chi-bot <[email protected]>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Aug 22, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
b216246 
)

ref pingcap#9344
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Aug 25, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
c6b5feb 
)

ref pingcap#9344
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Sep 20, 2023
@CharlesCheung96
pkg/orchestrator(ticdc): add timeout before remove capture (pingcap#9445
1b3c594 
)

ref pingcap#9344
ti-chi-bot bot pushed a commit that referenced this pull request Sep 20, 2023
@ti-chi-bot
pkg/orchestrator(ticdc): add timeout before remove capture (#9445) (#…
4d7b070 
…9457)

ref #9344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@asddongmen asddongmen asddongmen approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharlesCheung96 @ti-chi-bot @3AceShowHand @asddongmen @nongfushanquan