Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql (ticdc): only set write source when downstream is supported #9175

Merged
merged 3 commits into from
Jun 15, 2023
Merged

mysql (ticdc): only set write source when downstream is supported #9175

merged 3 commits into from
Jun 15, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jun 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9180

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 12, 2023
@asddongmen asddongmen requested review from hicqu and Rustin170506 June 12, 2023 04:01
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 13, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen asddongmen added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 14, 2023
@asddongmen
Copy link
Contributor Author

/test verify

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 09:57:19.808149116 +0000 UTC m=+79636.222753191: ☑️ agreed by sdojjy.
  • 2023-06-14 10:30:59.395981764 +0000 UTC m=+168055.810585841: ☑️ agreed by CharlesCheung96.

@asddongmen
Copy link
Contributor Author

/test pull-dm-integration-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

@asddongmen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify

In response to this:

/test pull-dm-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen
Copy link
Contributor Author

/merge

@asddongmen
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 72afa81 into pingcap:master Jun 15, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9236.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 15, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 15, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#9175
a7a9b34 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9237.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 15, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
mysql (ticdc): only set write source when downstream is supported (#9175
cabb1c0 
) (#9237)

close #9180
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
@ti-chi-bot
mysql (ticdc): only set write source when downstream is supported (#9175
647516c 
) (#9236)

close #9180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@sdojjy sdojjy sdojjy approved these changes

@hicqu hicqu Awaiting requested review from hicqu

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@asddongmen @ti-chi-bot @sdojjy @CharlesCheung96