Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd (ticdc): add grpc keepalive params and add timeout for check pd version ctx. #9106

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented May 31, 2023

What problem does this PR solve?

Issue Number: close #8808

What is changed and how it works?

  1. Added two grpc parameters when creating the etcd client (increased fault tolerance)
  2. Increased the number of retries for etcdClient api calls (increased fault tolerance)
  3. Added a timeout to the ctx for checkPDVersion (prevents hanging)

These are very small changes.

Currently tested 30 times, test results show that the highest delay of changefeed is 5 minutes, the lowest delay is zero, and the average delay is about 1 minute. The cause of the delay is that some cdc nodes will restart capture due to etcd session disconnect, which cannot be avoided; increasing the value of capture-session-ttl can slightly reduce the probability of this happening, but it cannot be completely avoided.

This PR cannot completely solve the problem of cdc delays when pd leader io hang errors are injected. Currently, the test results are quite mysterious, with 5 out of 10 times having issues and 5 times not having issues.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix cdc hang when pd leader network partitioned.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen asddongmen changed the title [WIP] use all pd endpoints to create etcd client etcd (ticdc): use all pd endpoints to create etcd client Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2023
@asddongmen asddongmen changed the title etcd (ticdc): use all pd endpoints to create etcd client etcd (ticdc): add grpc keepalive params and add timeout for check pd version ctx. Jun 1, 2023
@asddongmen asddongmen requested a review from sdojjy June 1, 2023 09:09
@asddongmen
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2023
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2bf6322

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9117.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9118.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc lag is more than 10m after inject pdleader network partition to all
4 participants